Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

812 account tabs #815

Merged
merged 9 commits into from
Feb 8, 2024
Merged

812 account tabs #815

merged 9 commits into from
Feb 8, 2024

Conversation

kylanhurt
Copy link
Contributor

@kylanhurt kylanhurt commented Dec 5, 2023 •
edited by donnyquixotic
Loading

Fixes #812 #822

Description

See issue descriptions

Test scenarios

  1. Go to an account and play around with the tabs
  2. Go to a different account and view those tabs
  3. Press browser's "back" button to get back to original account
  4. Make sure that each account tab reflects the current account's information

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 638b39e
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/65c42014515014000826cbcf
😎 Deploy Preview https://deploy-preview-815--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit 638b39e
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/65c4201445087900086ac8b3
😎 Deploy Preview https://deploy-preview-815--obe-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

donnyquixotic
donnyquixotic suggested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@donnyquixotic donnyquixotic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylanhurt the account reactivity is working as expected, still need to update tab selection if route includes tab param

  • account page should be reactive to both account change and tab query params on browser navigation

On browser navigation it should reflect the tab defined in the route param, if there isn't a param, it should default to 'transactions' tab.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 14, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 638b39e
Status: ✅  Deploy successful!
Preview URL: https://31d77960.open-block-explorer.pages.dev
Branch Preview URL: https://812-account-tabs.open-block-explorer.pages.dev

View logs

@donnyquixotic
Copy link
Contributor

donnyquixotic commented Dec 21, 2023 •
edited
Loading

@kylanhurt
There's still an issue with the previous tab persisting on navigation and the default tab when no pagination settings are set should be 'transactions'.

Steps to reproduce:

  1. Navigate to an account page and select a tab, e.g. 'keys'
  2. Search or otherwise navigate to a different account and select a different tab e.g. 'votes'
  3. Navigate back once, see tab query param removed but tab selection persisting (should default to 'transactions')
  4. Navigate back to first account viewed see 'votes' tab still active despite query params for 'keys' tab

@donnyquixotic donnyquixotic self-assigned this Feb 7, 2024
donnyquixotic
donnyquixotic previously approved these changes Feb 7, 2024
View reviewed changes
@donnyquixotic donnyquixotic merged commit 082a049 into develop Feb 8, 2024
10 checks passed
@donnyquixotic donnyquixotic deleted the 812-account-tabs branch February 8, 2024 00:31
@donnyquixotic donnyquixotic mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnyquixotic donnyquixotic donnyquixotic left review comments

Assignees

@donnyquixotic donnyquixotic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylanhurt @donnyquixotic